[INFO] cloning repository https://github.com/matt-porter/bish-bash-bosh
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/matt-porter/bish-bash-bosh" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmatt-porter%2Fbish-bash-bosh", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmatt-porter%2Fbish-bash-bosh'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 761f433307d37b22581e7ca602194cde5e94dd00
[INFO] checking matt-porter/bish-bash-bosh against master#c0bb140a37c81cf59a0b40c21c9413059644e294 for pr-129249-1
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmatt-porter%2Fbish-bash-bosh" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/matt-porter/bish-bash-bosh
[INFO] finished tweaking git repo https://github.com/matt-porter/bish-bash-bosh
[INFO] tweaked toml for git repo https://github.com/matt-porter/bish-bash-bosh written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/matt-porter/bish-bash-bosh on toolchain c0bb140a37c81cf59a0b40c21c9413059644e294
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c0bb140a37c81cf59a0b40c21c9413059644e294" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/matt-porter/bish-bash-bosh already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c0bb140a37c81cf59a0b40c21c9413059644e294" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr] warning: `agents` (manifest) generated 1 warning
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded cfg-if v0.1.2
[INFO] [stderr]   Downloaded rand v0.4.2
[INFO] [stderr]   Downloaded rand v0.3.22
[INFO] [stderr]   Downloaded bitflags v0.7.0
[INFO] [stderr]   Downloaded hsl v0.1.1
[INFO] [stderr]   Downloaded num-integer v0.1.36
[INFO] [stderr]   Downloaded bitflags v1.0.1
[INFO] [stderr]   Downloaded num-iter v0.1.35
[INFO] [stderr]   Downloaded c_vec v1.3.0
[INFO] [stderr]   Downloaded rand_core v0.1.0
[INFO] [stderr]   Downloaded num-traits v0.2.2
[INFO] [stderr]   Downloaded sdl2 v0.31.0
[INFO] [stderr]   Downloaded rand v0.5.0-pre.1
[INFO] [stderr]   Downloaded sdl2-sys v0.31.0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3e793bdf10248eb2ddbd6b0faebed8155c11b4589982e2893733958d93e8d540" "sleep" "infinity", kill_on_drop: false }`
[INFO] [stdout] bcf0846ac36935c8dfc2c23fd1f2c113693b92c82ac51bf4c59734aecfee2f92
[INFO] running `Command { std: "docker" "start" "bcf0846ac36935c8dfc2c23fd1f2c113693b92c82ac51bf4c59734aecfee2f92", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "bcf0846ac36935c8dfc2c23fd1f2c113693b92c82ac51bf4c59734aecfee2f92" "/opt/rustwide/cargo-home/bin/cargo" "+c0bb140a37c81cf59a0b40c21c9413059644e294" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "bcf0846ac36935c8dfc2c23fd1f2c113693b92c82ac51bf4c59734aecfee2f92", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "bcf0846ac36935c8dfc2c23fd1f2c113693b92c82ac51bf4c59734aecfee2f92" "/opt/rustwide/cargo-home/bin/cargo" "+c0bb140a37c81cf59a0b40c21c9413059644e294" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stderr] warning: Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr] warning: `agents` (manifest) generated 1 warning
[INFO] [stderr]     Checking num-traits v0.2.2
[INFO] [stderr]    Compiling cfg-if v0.1.2
[INFO] [stderr]     Checking rand v0.4.2
[INFO] [stderr]     Checking c_vec v1.3.0
[INFO] [stderr]     Checking rand_core v0.1.0
[INFO] [stderr]     Checking bitflags v0.7.0
[INFO] [stderr]     Checking hsl v0.1.1
[INFO] [stderr]    Compiling sdl2-sys v0.31.0
[INFO] [stderr]     Checking rand v0.5.0-pre.1
[INFO] [stderr]     Checking num-integer v0.1.36
[INFO] [stderr]     Checking num-iter v0.1.35
[INFO] [stderr]     Checking num v0.1.42
[INFO] [stderr]     Checking rand v0.3.22
[INFO] [stderr]     Checking sdl2 v0.31.0
[INFO] [stderr]     Checking agents v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/main.rs:273:34
[INFO] [stdout]     |
[INFO] [stdout] 273 |                         let sf = (100f64 / surface.height() as f64);
[INFO] [stdout]     |                                  ^                                ^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 273 -                         let sf = (100f64 / surface.height() as f64);
[INFO] [stdout] 273 +                         let sf = 100f64 / surface.height() as f64 ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around assigned value
[INFO] [stdout]    --> src/main.rs:273:34
[INFO] [stdout]     |
[INFO] [stdout] 273 |                         let sf = (100f64 / surface.height() as f64);
[INFO] [stdout]     |                                  ^                                ^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 273 -                         let sf = (100f64 / surface.height() as f64);
[INFO] [stdout] 273 +                         let sf = 100f64 / surface.height() as f64 ;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]    --> src/main.rs:272:29
[INFO] [stdout]     |
[INFO] [stdout] 272 |                         let mut surface = load_image(&filename);
[INFO] [stdout]     |                             ----^^^^^^^
[INFO] [stdout]     |                             |
[INFO] [stdout]     |                             help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `RandomPositionStrategy` is never constructed
[INFO] [stdout]   --> src/main.rs:37:8
[INFO] [stdout]    |
[INFO] [stdout] 37 | struct RandomPositionStrategy {}
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]    --> src/main.rs:101:22
[INFO] [stdout]     |
[INFO] [stdout] 101 | fn load_image(fname: &str) -> Surface {
[INFO] [stdout]     |                      ^^^^     ^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |                      |
[INFO] [stdout]     |                      the lifetime is elided here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]     = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]     |
[INFO] [stdout] 101 | fn load_image(fname: &str) -> Surface<'_> {
[INFO] [stdout]     |                                      ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]    --> src/main.rs:272:29
[INFO] [stdout]     |
[INFO] [stdout] 272 |                         let mut surface = load_image(&filename);
[INFO] [stdout]     |                             ----^^^^^^^
[INFO] [stdout]     |                             |
[INFO] [stdout]     |                             help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `RandomPositionStrategy` is never constructed
[INFO] [stdout]   --> src/main.rs:37:8
[INFO] [stdout]    |
[INFO] [stdout] 37 | struct RandomPositionStrategy {}
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]    --> src/main.rs:101:22
[INFO] [stdout]     |
[INFO] [stdout] 101 | fn load_image(fname: &str) -> Surface {
[INFO] [stdout]     |                      ^^^^     ^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |                      |
[INFO] [stdout]     |                      the lifetime is elided here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]     = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]     |
[INFO] [stdout] 101 | fn load_image(fname: &str) -> Surface<'_> {
[INFO] [stdout]     |                                      ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.35s
[INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: bitflags v0.7.0
[INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`
[INFO] running `Command { std: "docker" "inspect" "bcf0846ac36935c8dfc2c23fd1f2c113693b92c82ac51bf4c59734aecfee2f92", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "bcf0846ac36935c8dfc2c23fd1f2c113693b92c82ac51bf4c59734aecfee2f92", kill_on_drop: false }`
[INFO] [stdout] bcf0846ac36935c8dfc2c23fd1f2c113693b92c82ac51bf4c59734aecfee2f92
